Date wrong and datepicker error in locale pt_BR

Hi,

In locale pt_BR, dates are been displayed incorrectly. Dates are been displayed as “06 De jun De 2018” when the correct is “06 de jun de 2018” as per PHP IntlDateFormatter. While it is not a big deal, the real problem is in datepicker thats picks a wrong date, as below:

Inspecting code generate, you can see the locale.settings variable has a wrong values for jquery_ui, moment and php (intl is fine):

PHP

require({ config: { 'orolocale/js/locale-settings': { defaults: {"locale":"en","language":"en","country":"US","currency":"USD"}, settings: {"locale":"pt_BR","language":"pt_BR","country":"BR","currency":"BRL", "timezone":"America\/Sao_Paulo","timezone_offset":"-03:00","format_address_by_address_country":true, "apiKey":"AIzaSyBX2aSeriuXdf-GWRhzxDI9w8wQzBUhpQU","unit":{"temperature":"celsius","wind_speed":"kilometers_per_hour"}, "format":{"datetime":{"jquery_ui":{"day":"","date":"d d M d yy","time":"HH:mm","datetime":"d d M d yy HH:mm"}, "intl":{"day":"","date":"d 'de' MMM 'de' y","time":"HH:mm","datetime":"d 'de' MMM 'de' y HH:mm"}, "moment":{"day":"","date":"D [De] MMM [De] YYYY","time":"HH:mm","datetime":"D [De] MMM [De] YYYY HH:mm"}, "php":{"day":"","date":"j j M j Y","time":"H:i","datetime":"j j M j Y H:i"}}, ....

1 2 3 4 5 6 7 8 9 10 11 12

require({     config: {         'orolocale/js/locale-settings': {             defaults: {"locale":"en","language":"en","country":"US","currency":"USD"},             settings: {"locale":"pt_BR","language":"pt_BR","country":"BR","currency":"BRL", "timezone":"America\/Sao_Paulo","timezone_offset":"-03:00","format_address_by_address_country":true, "apiKey":"AIzaSyBX2aSeriuXdf-GWRhzxDI9w8wQzBUhpQU","unit":{"temperature":"celsius","wind_speed":"kilometers_per_hour"}, "format":{"datetime":{"jquery_ui":{"day":"","date":"d d M d yy","time":"HH:mm","datetime":"d d M d yy HH:mm"},                       "intl":{"day":"","date":"d 'de' MMM 'de' y","time":"HH:mm","datetime":"d 'de' MMM 'de' y HH:mm"},       "moment":{"day":"","date":"D [De] MMM [De] YYYY","time":"HH:mm","datetime":"D [De] MMM [De] YYYY HH:mm"},       "php":{"day":"","date":"j j M j Y","time":"H:i","datetime":"j j M j Y H:i"}}, ....

Where the correct should be:

PHP

"format":{"datetime":{"jquery_ui":{"day":"","date":"d 'de' M 'de' yy","time":"HH:mm","datetime":"d 'de' M 'de' yy HH:mm"}, "intl":{"day":"","date":"d 'de' MMM 'de' y","time":"HH:mm","datetime":"d 'de' MMM 'de' y HH:mm"}, "moment":{"day":"","date":"D [de] MMM [de] YYYY","time":"HH:mm","datetime":"D [de] MMM [de] YYYY HH:mm"}, "php":{"day":"","date":"j 'de' M 'de' Y","time":"H:i","datetime":"j 'de' M 'de' Y H:i"}},

1 2 3 4

"format":{"datetime":{"jquery_ui":{"day":"","date":"d 'de' M 'de' yy","time":"HH:mm","datetime":"d 'de' M 'de' yy HH:mm"},                       "intl":{"day":"","date":"d 'de' MMM 'de' y","time":"HH:mm","datetime":"d 'de' MMM 'de' y HH:mm"},                       "moment":{"day":"","date":"D [de] MMM [de] YYYY","time":"HH:mm","datetime":"D [de] MMM [de] YYYY HH:mm"},                       "php":{"day":"","date":"j 'de' M 'de' Y","time":"H:i","datetime":"j 'de' M 'de' Y H:i"}},

May I missing something in configuration?

Also, how can I chance default format for a pattern like ‘dd/MM/yyyy’ in whole site context?

Regards,

Topic

[msulimaModerator]

Hi, mario.pinho.

I made little debug and discovered that it is bug in AbstractDateTimeFormatConverter class.
Probably you can temporary fix this bug by adding

PHP

'\'de\'' => '',

1	'\'de\'' => '',

to formatting array https://github.com/oroinc/platform/blob/2.6/src/Oro/Bundle/LocaleBundle/Converter/AbstractDateTimeFormatConverter.php#L23.

how can I chance default format for a pattern like ‘dd/MM/yyyy’ in whole site context?

As I know now you can’t do that for all application.

---

Check our free technical guide ”How to Build a Reliable and Secure Infrastructure for OroCommerce”.

[mario.pinhoParticipant]

Hi, msulima!

Your suggestion is not fully operational, it only removes word “de” from format and it is not correct. In portuguese and spanish (may be in some other languages) the preposition “de” (“of” in english) is necessary for FULL and MEDIUM formats, so I suggest the function convertFormat as follow:

PHP

protected function convertFormat($format) { $formatMatch = array_merge($this->defaultFormatMatch, $this->formatMatch); // merge formats $tokens = preg_split("/[\s,\.]+/", $format, -1, PREG_SPLIT_OFFSET_CAPTURE); // tokenize $format $new_format = ''; $start = 0; foreach ($tokens as $token) { if (isset($formatMatch[$token[0]])) { $new_format .= substr($format, $start, $token[1] - $start) . $formatMatch[$token[0]]; $start = $token[1] + strlen($token[0]); } } return $new_format . substr($format, $start); }

1 2 3 4 5 6 7 8 9 10 11 12 13 14

protected function convertFormat($format)     {         $formatMatch = array_merge($this->defaultFormatMatch, $this->formatMatch); // merge formats         $tokens = preg_split("/[\s,\.]+/", $format, -1, PREG_SPLIT_OFFSET_CAPTURE); // tokenize $format         $new_format = '';         $start = 0;         foreach ($tokens as $token) {             if (isset($formatMatch[$token[0]])) {                 $new_format .= substr($format, $start, $token[1] - $start) . $formatMatch[$token[0]];                 $start = $token[1] + strlen($token[0]);             }         }         return $new_format . substr($format, $start);     }

The ideia is tokenize the format e convert only tokens present in formatMatch. I do this directly in AbstractDateTimeFormatConverter, and remove convertFormat from PhpDateTimeFormatConverter and JqueryUiDateTimeFormatConverter because chars ‘ and ” are necessary. MomentDateTimeFormatConverter is fine. Now, everything is working correctly.

Now, I’m facing a different problem. Im my Bundle, I create an extension as described in “How to Extend Existing Bundle” for classes AbstractDateTimeFormatConverter, PhpDateTimeFormatConverter and JqueryUiDateTimeFormatConverter, made de changes in services.yml but it is not working. I tried to extend de classes and make new ones, no success. For sure, I’m missing something. Can you help me what must I do to extend these classes?

[msulimaModerator]

Can you please show your bundles.yml and services.yml?

---

Check our free technical guide ”How to Build a Reliable and Secure Infrastructure for OroCommerce”.

[mario.pinhoParticipant]

My bundles.yml:

PHP

bundles: # priority should be higher then priority of OroLocaleBundle - { name: AgClick\Bundle\LocaleBundle\AgClickLocaleBundle, priority: 10 }

1 2 3

bundles: # priority should be higher then priority of OroLocaleBundle     - { name: AgClick\Bundle\LocaleBundle\AgClickLocaleBundle, priority: 10 }

My services.yml:

PHP

parameters: oro_locale.format_converter.date_time.php.class: AgClick\Bundle\LocaleBundle\Converter\PhpDateTimeFormatConverter service: oro_locale.format_converter.date_time.php: class: %oro_locale.format_converter.date_time.php.class% arguments: - '@oro_locale.formatter.date_time' - '@translator' tags: - { name: oro_locale.format_converter.date_time, alias: php }

1 2 3 4 5 6 7 8 9 10 11

parameters:     oro_locale.format_converter.date_time.php.class: AgClick\Bundle\LocaleBundle\Converter\PhpDateTimeFormatConverter   service:     oro_locale.format_converter.date_time.php:         class: %oro_locale.format_converter.date_time.php.class%         arguments:             - '@oro_locale.formatter.date_time'             - '@translator'         tags:             - { name: oro_locale.format_converter.date_time, alias: php }

• This reply was modified 5 years, 10 months ago by  mario.pinho.

[Author]

Replies