Data Grid is showing records of other organization as well…

I have build a custom bundle called promotions on oro platform & it has an entity called Promotion. The data grid for promotion shows all the records from the table. I want to show only records that belong to the user organization.

But don’t allow to do any operations such as edit, delete etc on such records. ACL is not applied properly ?

What am doing wrong here ?

My Entity code is below :

PHP

<?php /** * Created by PhpStorm. * User: Sachin * Date: 21-09-2017 * Time: 09:46 PM */ namespace Hko\Bundle\PromotionBundle\Entity; use Doctrine\ORM\Mapping as ORM; use Oro\Bundle\EntityConfigBundle\Metadata\Annotation\Config; use Oro\Bundle\EntityConfigBundle\Metadata\Annotation\ConfigField; use Gedmo\SoftDeleteable\SoftDeleteable; use \Gedmo\SoftDeleteable\Traits\SoftDeleteable as SoftDeleteableTraits; use Oro\Bundle\EntityBundle\EntityProperty\DatesAwareTrait; use Oro\Bundle\OrganizationBundle\Entity\OrganizationAwareInterface; use Oro\Bundle\OrganizationBundle\Entity\Ownership\OrganizationAwareTrait; use Hko\Bundle\PromotionBundle\Model\ExtendPromotion; use Oro\Bundle\OrganizationBundle\Entity\OrganizationInterface; /** * @ORM\Table("hko_promotions") * @ORM\Entity(repositoryClass="Hko\Bundle\PromotionBundle\Entity\Repository\PromotionRepository") * @Config( * routeName="hkoPromotion.promotion_index", * routeView="hkoPromotion.promotion_view", * routeCreate="hkoPromotion.promotion_create", * routeUpdate="hkoPromotion.promotion_update", * defaultValues={ * "security"={ * "type"="ACL", * "group_name"="", * "permissions"="All", * "category"="account_management" * }, * * "ownership"={ * "owner_type"="ORGANIZATION", * "organization_field_name"="organization", * "organization_column_name"="organization_id", * } * } * ) */ class Promotion extends ExtendPromotion implements OrganizationAwareInterface, SoftDeleteable { use OrganizationAwareTrait; use SoftDeleteableTraits; use DatesAwareTrait; /** * @var integer * * @ORM\Column(name="id", type="integer") * @ORM\Id * @ORM\GeneratedValue(strategy="AUTO") */ protected $id; /** * @var string * @ORM\Column(name="name", type="string",nullable=true) */ protected $name; /** * @var string * @ORM\Column(name="coupon_code", type="string",nullable=true) */ protected $couponCode; /** * @var Organization * @ORM\ManyToOne(targetEntity="Oro\Bundle\OrganizationBundle\Entity\Organization") * @ORM\JoinColumn(name="organization_id", referencedColumnName="id", onDelete="SET NULL") */ protected $organization; /** * Get id * * @return integer */ public function getId() { return $this->id; } /** * Set name * * @param string $name * * @return Promotion */ public function setName($name) { $this->name = $name; return $this; } /** * Get name * * @return string */ public function getName() { return $this->name; } /** * Set couponCode * * @param string $couponCode * * @return Promotion */ public function setCouponCode($couponCode) { $this->couponCode = $couponCode; return $this; } /** * Get couponCode * * @return string */ public function getCouponCode() { return $this->couponCode; } /** * @param OrganizationInterface $organization * * @return $this */ public function setOrganization(OrganizationInterface $organization) { $this->organization = $organization; return $this; } /** * @return OrganizationInterface */ public function getOrganization() { return $this->organization; } }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167

<?php /** * Created by PhpStorm. * User: Sachin * Date: 21-09-2017 * Time: 09:46 PM */   namespace Hko\Bundle\PromotionBundle\Entity;   use Doctrine\ORM\Mapping as ORM; use Oro\Bundle\EntityConfigBundle\Metadata\Annotation\Config; use Oro\Bundle\EntityConfigBundle\Metadata\Annotation\ConfigField; use Gedmo\SoftDeleteable\SoftDeleteable; use \Gedmo\SoftDeleteable\Traits\SoftDeleteable as SoftDeleteableTraits; use Oro\Bundle\EntityBundle\EntityProperty\DatesAwareTrait; use Oro\Bundle\OrganizationBundle\Entity\OrganizationAwareInterface; use Oro\Bundle\OrganizationBundle\Entity\Ownership\OrganizationAwareTrait; use Hko\Bundle\PromotionBundle\Model\ExtendPromotion; use Oro\Bundle\OrganizationBundle\Entity\OrganizationInterface;   /** * @ORM\Table("hko_promotions") * @ORM\Entity(repositoryClass="Hko\Bundle\PromotionBundle\Entity\Repository\PromotionRepository") * @Config( *      routeName="hkoPromotion.promotion_index", *      routeView="hkoPromotion.promotion_view", *      routeCreate="hkoPromotion.promotion_create", *      routeUpdate="hkoPromotion.promotion_update", *      defaultValues={ *          "security"={ *              "type"="ACL", *              "group_name"="", *              "permissions"="All", *              "category"="account_management" *         }, * *        "ownership"={ *              "owner_type"="ORGANIZATION", *              "organization_field_name"="organization", *              "organization_column_name"="organization_id", *          } *     } * ) */ class Promotion extends ExtendPromotion implements     OrganizationAwareInterface,     SoftDeleteable {       use OrganizationAwareTrait;     use SoftDeleteableTraits;     use DatesAwareTrait;       /**      * @var integer      *      * @ORM\Column(name="id", type="integer")      * @ORM\Id      * @ORM\GeneratedValue(strategy="AUTO")      */     protected $id;       /**      * @var string      * @ORM\Column(name="name", type="string",nullable=true)      */     protected $name;         /**      * @var string      * @ORM\Column(name="coupon_code", type="string",nullable=true)      */     protected $couponCode;           /**      * @var Organization      * @ORM\ManyToOne(targetEntity="Oro\Bundle\OrganizationBundle\Entity\Organization")      * @ORM\JoinColumn(name="organization_id", referencedColumnName="id", onDelete="SET NULL")      */     protected $organization;       /**      * Get id      *      * @return integer      */     public function getId()     {         return $this->id;     }       /**      * Set name      *      * @param string $name      *      * @return Promotion      */     public function setName($name)     {         $this->name = $name;           return $this;     }       /**      * Get name      *      * @return string      */     public function getName()     {         return $this->name;     }       /**      * Set couponCode      *      * @param string $couponCode      *      * @return Promotion      */     public function setCouponCode($couponCode)     {         $this->couponCode = $couponCode;           return $this;     }       /**      * Get couponCode      *      * @return string      */     public function getCouponCode()     {         return $this->couponCode;     }            /**      * @param OrganizationInterface $organization      *      * @return $this      */     public function setOrganization(OrganizationInterface $organization)     {         $this->organization = $organization;           return $this;     }       /**      * @return OrganizationInterface      */     public function getOrganization()     {         return $this->organization;     }      }

Topic

[akhristiansenParticipant]

Hello, @sachingk.30!
Try to modify ownership like this

PHP

* "ownership"={ * "owner_type"="BUSINESS_UNIT", * "owner_field_name"="owner", * "owner_column_name"="business_unit_owner_id", * "organization_field_name"="organization", * "organization_column_name"="organization_id" * }, * "security"={ * "type"="ACL", * "group_name"="", * "category"="marketing" * },

1 2 3 4 5 6 7 8 9 10 11 12

*          "ownership"={ *              "owner_type"="BUSINESS_UNIT", *              "owner_field_name"="owner", *              "owner_column_name"="business_unit_owner_id", *              "organization_field_name"="organization", *              "organization_column_name"="organization_id" *          }, *          "security"={ *              "type"="ACL", *              "group_name"="", *              "category"="marketing" *          },

and add proper fields

PHP

@ORM\ManyToOne(targetEntity="Oro\Bundle\OrganizationBundle\Entity\BusinessUnit", cascade={"persist"}) * @ORM\JoinColumn(name="business_unit_owner_id", referencedColumnName="id", onDelete="SET NULL") * @ConfigField( * defaultValues={ * "importexport"={ * "excluded"=true * } * } * ) */ protected $owner; /** * @return BusinessUnit */ public function getOwner() { return $this->owner; } /** * @param BusinessUnit $owningBusinessUnit * * @return User */ public function setOwner($owningBusinessUnit) { $this->owner = $owningBusinessUnit; return $this; }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32

@ORM\ManyToOne(targetEntity="Oro\Bundle\OrganizationBundle\Entity\BusinessUnit", cascade={"persist"})      * @ORM\JoinColumn(name="business_unit_owner_id", referencedColumnName="id", onDelete="SET NULL")      * @ConfigField(      *      defaultValues={      *          "importexport"={      *              "excluded"=true      *          }      *      }      * )      */     protected $owner;         /**      * @return BusinessUnit      */     public function getOwner()     {         return $this->owner;     }       /**      * @param BusinessUnit $owningBusinessUnit      *      * @return User      */     public function setOwner($owningBusinessUnit)     {         $this->owner = $owningBusinessUnit;           return $this;     }

Also, please, remember, that entity can have not only one organization ( UserBundle/Entity/User.phpUser.php entity as example) because of that it is not a good idea to set organisation as owner. Usually, oro entities has User or bussines unit as owners.

Also it is important to check your role in system – you must have admin rights and belong to business unit that have relation to your entity.

[Author]

Replies