The import (channel) doesn't update last sync date – onFinish() listener. Why?

Hello,

I have an orders/customers import based on API which has been created on a channel. I have noticed that when an API call returns an empty array then the script jump to onFinish() in my listener import method where supposed to update last sync date, but when an API call is empty then the script doesn’t update this date. Why is that? There is no any PHP condition to prevent it. This part of code should be always done.

Topic

[Andrey YatsenkoModerator]

Hi Adam,
Can you share code of the listener you created and the declaration in services.yml to understand to what event it subscribed and that subscription made right?

[AdamParticipant]

Hi Andrey,

Part of the listener onFinish() method:

if ($car instanceof Car) { $carManager = $this->doctrine->getEntityManager(Car::class); $lastSyncDate = clone $car->getLastSyncDate(); $lastSyncDate->modify(sprintf('+%d minute', 60)); $car->setLastSyncDate($lastSyncDate); $carManager->persist($car); $carManager->flush($car); }

1 2 3 4 5 6 7 8 9 10

if ($car instanceof Car) {     $carManager = $this->doctrine->getEntityManager(Car::class);     $lastSyncDate = clone $car->getLastSyncDate();     $lastSyncDate->modify(sprintf('+%d minute', 60));     $car->setLastSyncDate($lastSyncDate);     $carManager->persist($car);     $carManager->flush($car); }

services.yml

adam.api_import.order_listener.order_import_sync_date: class: Adam\Bundle\APIImport\OrderListener\OrderImportSyncDateEventListener arguments: - "@oro_entity.doctrine_helper" tags: - { name: kernel.event_listener, event: oro_integration.event.sync_after, method: onFinish }

1 2 3 4 5 6 7 8

adam.api_import.order_listener.order_import_sync_date: class: Adam\Bundle\APIImport\OrderListener\OrderImportSyncDateEventListener arguments: - "@oro_entity.doctrine_helper" tags: - { name: kernel.event_listener, event: oro_integration.event.sync_after, method: onFinish }

There is nothing tricky. There is something in ORO CRM what prevents to update this last sync date when API request is empty, but I need to update this date. It’s crucial.

• This reply was modified 5 years, 11 months ago by  Adam.
• This reply was modified 5 years, 11 months ago by  Adam.
• This reply was modified 5 years, 11 months ago by  Adam.

[AdamParticipant]

There are no error logs in log files as well. /app/logs/

• This reply was modified 5 years, 11 months ago by  Adam.

[Andrey YatsenkoModerator]

Do you have any related errors in log. The event can not be triggered when sync finished with errors?

[AdamParticipant]

There are no errors in /app/logs/, nothing in there. It does not make any sense. I have tested couple different scenarios and if an API call doesn’t return anything then CRM doesn’t update last sync date. If there are orders in the API call ORO updates date.

• This reply was modified 5 years, 11 months ago by  Adam.

[AdamParticipant]

Should I use this method:

PHP

computeChangeSet()

1	computeChangeSet()

rather than:

PHP

flush()

1

flush()

????

[Andrey YatsenkoModerator]

Don’t think so, as computeChangeSet is internal doctrine thing and it should be used only on doctrine listeners. Also everything should be already flushed so event called out of transaction there is no reason to work directly with UnitOfWork

[Andrey YatsenkoModerator]

You can debug message consumer, starting from this method \Oro\Bundle\IntegrationBundle\Async\SyncIntegrationProcessor::process to see whats happening on API returing empty result.
I recently recorded a video how to debug message consumer, this may help

[AdamParticipant]

I have found this PHP computeChangeSet() method in oro crm doc, see below:

https://oroinc.com/orocrm/doc/2.3/cookbook/how-to-add-entity-event-listeners#configuring-the-listener

[Andrey YatsenkoModerator]

You are subscribing to different type of event. computeChangeSet should be used only for doctrine event listeners.

[AdamParticipant]

oh, right! I understand it now. However, still don’t know what could happen?

[AdamParticipant]

@Andrey, I have swapped to computeChangeSet() method and it’s working. It saves all of the values.

[Andrey YatsenkoModerator]

Just checked the doctrine code.
EntityManager::flush() just call UnitOfWork::commit() that call computeChangeSet in case you don’t pass any arguments to ‘flush’
https://github.com/doctrine/doctrine2/blob/2.5/lib/Doctrine/ORM/UnitOfWork.php#L340

But it also do a lot of other work, like dispatching events, so calling ‘computeChangeSet’ outside of doctrine event listener is not safe as it will not trigger listeners to this or related entities and broke some other staff like inserting new related entities.

So it’s recommended to replace computeChangeSet with flush back, but don’t pass arguments to it.

Just change

PHP

$carManager->persist($car); $carManager->flush($car);

1 2	$carManager->persist($car); $carManager->flush($car);

to

PHP

$carManager->flush();

1	$carManager->flush();

• This reply was modified 5 years, 11 months ago by  Andrey Yatsenko.
• This reply was modified 5 years, 11 months ago by  Andrey Yatsenko.
• This reply was modified 5 years, 7 months ago by  Mike Luskavets.

[AdamParticipant]

Sorry, I have used this recomputeSingleEntityChangeSet().

Please, take a look at this tutorial regards to this method:

http://vvv.tobiassjosten.net/symfony/update-associated-entities-in-doctrine/

What about this method? However, your solution with use only flush() works as well :)

I have no idea, how is this even possible, that once it works, in another case it doesn’t work… magic.

[AdamParticipant]

It was triggered but the changes made to the series were not persisted to the database. Since you do not have access to the entity manager in these callbacks, there is furthermore no way to force a persist/flush from here.

[Author]

Replies