Trying add Xing to social_url_format

Hi,

I want to expand the definitions in the File vendor/oro/crm/src/Oro/Bundle/ContactBundle/DependencyInjection/Configuration.php.

Try this in my Bundle:

class Configuration implements ConfigurationInterface
{
/**
* {@inheritDoc}
*/
public function getConfigTreeBuilder()
{
$treeBuilder = new TreeBuilder();
$rootNode = $treeBuilder->root('oro_contact');
SettingsBuilder::append(
$rootNode,
[
'social_url_format' => [
'value' => ['xing' => 'https://xing.com/profile/%%username%%']
]
]
);
return $treeBuilder;
}


But it doesnt work. Then i try this:

$treeBuilder = new TreeBuilder();
$rootNode = $treeBuilder->root('oro_contact')
->children()
->arrayNode('social_url_format');
SettingsBuilder::append(
$rootNode,
[
'xing' => [
'value' => ['value' => 'https://xing.com/profile/%%username%%']
]
]
);
return $treeBuilder;
}


Doesnt work either.

Can you give me a hint what i’m doing wrong ?

Topic

[adriwan_kenobyParticipant]

According to the doc, “Each option can get a default value and a type (one of scalar, boolean or array). The default type if none is specified is scalar”, so if you want to declare some array type config you should try :

SettingsBuilder::append($rootNode, [ 'social_url' => [ 'value' => [ 'https://xing.com/profile/%%username%%' , 'some_other_url' ], 'type' => 'array', ] ]);

1 2 3 4 5 6 7 8 9

SettingsBuilder::append($rootNode, [             'social_url' => [                 'value' => [                     'https://xing.com/profile/%%username%%'  ,                      'some_other_url'                 ],                 'type' => 'array',             ]         ]);

Moreover I don’t think that you can use associative array in conf

https://oroinc.com/orocrm/doc/2.0/book/configuration

[SkaiBoaParticipant]

Thx for your answer. That was a poor wording on my side for my problem.
I found in vendor/oro/crm/src/Oro/Bundle/ContactBundle/DependencyInjection/Configuration.php following

PHP

$treeBuilder = new TreeBuilder(); $treeBuilder->root('oro_contact') ->children() ->arrayNode('social_url_format') ->addDefaultsIfNotSet() ->children() ->scalarNode(Social::TWITTER) ->cannotBeEmpty() ->defaultValue('https://twitter.com/%%username%%') ->end() ->scalarNode(Social::FACEBOOK) ->cannotBeEmpty() ->defaultValue('https://www.facebook.com/%%username%%') ->end()

1 2 3 4 5 6 7 8 9 10 11 12 13 14

$treeBuilder = new TreeBuilder();         $treeBuilder->root('oro_contact')             ->children()                 ->arrayNode('social_url_format')                     ->addDefaultsIfNotSet()                     ->children()                         ->scalarNode(Social::TWITTER)                             ->cannotBeEmpty()                             ->defaultValue('https://twitter.com/%%username%%')                         ->end()                         ->scalarNode(Social::FACEBOOK)                             ->cannotBeEmpty()                             ->defaultValue('https://www.facebook.com/%%username%%')                         ->end()

There are four connections to social media but not Xong. Now I want to add it.
My last try:

PHP

$treeBuilder = new TreeBuilder(); $rootNode = $treeBuilder->root('oro_contact') ->children() ->arrayNode('social_url_format'); SettingsBuilder::append( $rootNode, [ 'xing' => [ 'value' => [ 'https://xing.com/profile/%%username%%' ] ] ]); return $treeBuilder;

1 2 3 4 5 6 7 8 9 10 11 12 13

$treeBuilder = new TreeBuilder();         $rootNode = $treeBuilder->root('oro_contact')             ->children()             ->arrayNode('social_url_format');         SettingsBuilder::append(             $rootNode, [             'xing' => [                 'value' => [                     'https://xing.com/profile/%%username%%'                 ]             ]         ]);         return $treeBuilder;

There are no errors through this configuration. But when I try to use Xing for social_url_format I will get:


An exception has been thrown during the rendering of a template ("Unknown social network type "xing"").


Maybe my configuration sucks or I miss some other for using Xing in social_url_format.

[Yurii MuratovParticipant]

Hello, @SkaiBoa.

Unfortunately, symfony does not support adding new parameters to the bundle configuration from another bundle and current configuration of ContactBundle does not allow to add custom format strings via bundle configuration.

But in your case, you can add your formatter string throw compiler pass.

Here is an example of such compiler:

PHP

<?php namespace Acme\Bundle\DemoBundle\DependencyInjection\Compiler; use Oro\Bundle\ContactBundle\DependencyInjection\OroContactExtension; use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; use Symfony\Component\DependencyInjection\ContainerBuilder; class SocialUrlFormatPass implements CompilerPassInterface { public function process(ContainerBuilder $container) { $container->setParameter( OroContactExtension::PARAMETER_SOCIAL_URL_FORMAT, array_merge( $container->getParameter(OroContactExtension::PARAMETER_SOCIAL_URL_FORMAT), [ 'xing' => 'https://xing.com/profile/%%username%%' ] ) ); } }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23

<?php   namespace Acme\Bundle\DemoBundle\DependencyInjection\Compiler;   use Oro\Bundle\ContactBundle\DependencyInjection\OroContactExtension; use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; use Symfony\Component\DependencyInjection\ContainerBuilder;   class SocialUrlFormatPass implements CompilerPassInterface {     public function process(ContainerBuilder $container)     {         $container->setParameter(             OroContactExtension::PARAMETER_SOCIAL_URL_FORMAT,             array_merge(                 $container->getParameter(OroContactExtension::PARAMETER_SOCIAL_URL_FORMAT),                 [                     'xing' => 'https://xing.com/profile/%%username%%'                 ]             )         );     } }

And the adding this compiler at the Bundle class:

PHP

<?php namespace Acme\Bundle\DemoBundle; use Acme\Bundle\DemoBundle\DependencyInjection\Compiler\SocialUrlFormatPass; use Symfony\Component\DependencyInjection\ContainerBuilder; use Symfony\Component\HttpKernel\Bundle\Bundle; class AcmeDemoBundle extends Bundle { /** * {@inheritdoc} */ public function build(ContainerBuilder $container) { parent::build($container); $container->addCompilerPass(new SocialUrlFormatPass()); } }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20

<?php   namespace Acme\Bundle\DemoBundle;   use Acme\Bundle\DemoBundle\DependencyInjection\Compiler\SocialUrlFormatPass; use Symfony\Component\DependencyInjection\ContainerBuilder; use Symfony\Component\HttpKernel\Bundle\Bundle;   class AcmeDemoBundle extends Bundle {     /**      * {@inheritdoc}      */     public function build(ContainerBuilder $container)     {         parent::build($container);           $container->addCompilerPass(new SocialUrlFormatPass());     } }

We will have a look at ContactBundle configuration and fix the impossibility to add and modify the social_url_format strings without additional code. (internal ID – CRM-8770)

[Author]

Replies