Update custom entity data using API PUT

Hi oro’s guys,
I have an issues when i try to update my custom entity using a REST API.

I create an entity with my own controller, my own Form type and handler.. etc..
To do that, i duplicate(almost) an existing case in the OroPlatform..

My problem seems to appear during the processForm, where the form submit do not hydrate data from the Request.

Do you have any idea where that is come from ?

Topic

[Alexandr SmagaParticipant]

Hello @kelton23om!
Could you please provide more details? Are you talking about REST api ? Are you working with named form ?

[kelton23omParticipant]

Hi,

Yes i talk about a REST API.. i try to build my own REST API to expose my Own webservices dedicates to my Custom entity.
To do that, i decided to follow an example as in the NotesBundle.. and it’s work pretty well for “delete” and “get” web services, but i encouter a problem when i try to PUT or POST some data.
After some explorations i realize that the problem come from the Form process method,
the submit method to be more precise who did not do the job!

# Oro\Bundle\SoapBundle\Form\Handler\ApiFormHandler /** * Process form * * @param mixed $entity * @return bool True on successful processing, false otherwise */ public function process($entity) { $this->form->setData($entity); if (in_array($this->request->getMethod(), array('POST', 'PUT'))) { $this->form->submit($this->request); if ($this->form->isValid()) { $this->onSuccess($entity); return true; } } return false; }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23

# Oro\Bundle\SoapBundle\Form\Handler\ApiFormHandler     /**      * Process form      *      * @param  mixed $entity      * @return bool  True on successful processing, false otherwise      */     public function process($entity)     {         $this->form->setData($entity);           if (in_array($this->request->getMethod(), array('POST', 'PUT'))) {             $this->form->submit($this->request);             if ($this->form->isValid()) {                 $this->onSuccess($entity);                   return true;             }         }           return false;     }

I don’t really known why, but the model Object is never hydrated by the request data..
whereas if i trace my request i can see form data in the parameter bag.

i expect that explains a bit more the situation.

thanks again to spend a bit of your time answer my questions :)

[Alexandr SmagaParticipant]

Can you share $this->form->getName(), var_dump(array_keys($this->form->all())) and var_dump($this->request->request->all()); ?

[kelton23omParticipant]

Hi, of course here it is:

$this->form->getName()

string 'tour_form_api' (length=13)

1	string 'tour_form_api' (length=13)

var_dump(array_keys($this->form->all()));

array (size=3) 0 => string 'idErp' (length=5) 1 => string 'name' (length=4) 2 => string 'driver' (length=6)

1	array (size=3)  0 => string 'idErp' (length=5)  1 => string 'name' (length=4)  2 => string 'driver' (length=6)

var_dump($this->request->request->all());

array (size=3) 'idErp' => string '666' (length=3) 'name' => string 'TEST' (length=4) 'driver' => string '1' (length=1)

1	array (size=3)  'idErp' => string '666' (length=3)  'name' => string 'TEST' (length=4)  'driver' => string '1' (length=1)

[Alexandr SmagaParticipant]

Hello.

Please try to use

$.post('/api/rest/latest/YOUR_API_METHOD, {tour_form_api: {idErp: 666, name: 'TEST', driver: 1}}).always(function(res) {console.log(res);})

1 2 3

$.post('/api/rest/latest/YOUR_API_METHOD, {tour_form_api: {idErp: 666, name: 'TEST', driver: 1}}).always(function(res) {console.log(res);})

[kelton23omParticipant]

Hi,

I’m not sure to do the right thing, but i get a 404 error !!!

:/

[kelton23omParticipant]

I found from where my issue came…

It’s because of the form service declaration and the way the RestController manage the request.

in “Oro\Bundle\SoapBundle\Controller\Api\Rest\RestController” the “fixRequestAttributes” method handle the parameters from Request.

the problem is that this method treats the request as a “GET” if the “Form” contains a name.

protected function fixRequestAttributes($entity) { $request = $this->container->get('request'); $formName = $this->getForm()->getName(); $data = empty($formName) ? $request->request->all() : $request->request->get($formName);

1 2 3 4 5 6 7

protected function fixRequestAttributes($entity)     {         $request = $this->container->get('request');         $formName = $this->getForm()->getName();         $data = empty($formName)             ? $request->request->all()             : $request->request->get($formName);

And of course in my case i put a name in my form declaration, in the “service.yml”:

gc.tour.form.api: class: Symfony\Component\Form\Form factory_method: createNamed factory_service: form.factory arguments: [tour_form_api, "tour", null]

1 2 3 4 5

gc.tour.form.api:         class: Symfony\Component\Form\Form         factory_method: createNamed         factory_service: form.factory         arguments: [tour_form_api, "tour", null]

So i just need to remove the name from the arguments like this:

gc.tour.form.api: class: Symfony\Component\Form\Form factory_method: createNamed factory_service: form.factory arguments: [null, "tour", null]

1 2 3 4 5 6

gc.tour.form.api:         class: Symfony\Component\Form\Form         factory_method: createNamed         factory_service: form.factory         arguments: [null, "tour", null]

that’s it :)

I’m not really sure about the meaning of the fixRequestAttributes method but it seems to have a quite strange behavior in my opinion!

thanks again!! keep going your good work

[Author]

Replies